Stop toolbar fan-out and folder panels from clipping their tooltips - #124
Merged
Conversation
The reveal is a clip-path wipe, so the clip has to exist while it animates — clip-path: none is discrete and snaps instead of interpolating. But clip-path clips every descendant, so leaving a zero inset in place after the wipe has landed slices off the hover tooltips of the outermost buttons, which paint outside the panel by design. Widening the settled inset is not a way out: the wipe front IS the inset travelling 100% -> 0, so bleeding it outward extends the travel and the reveal completes early (measured at ~95ms of a 350ms transition with a 32rem bleed). Release the clip once the reveal has landed instead, and put an interpolable inset back before a close begins, so both wipes keep their exact timing. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
.toolbar-slot-section was permanently overflow:hidden, which clipped the fan-out and folder panels of any ToolbarGroup that hosts a slot. ToolbarLayout already worked around this with an inline overflow override; move that to a --transitioning modifier class so both hosts share it and the section is only clipped while outgoing content is fading out. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
einari
force-pushed
the
fix/toolbar-panel-tooltip-clipping
branch
from
August 10, 2026 14:56
17db2b7 to
9b7b674
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed
ToolbarFanOutItempanel are no longer clipped at the panel's edge. The clip-path that drives the reveal wipe is now released once the wipe has landed, and restored before the panel closes, so both animations keep their exact timing.ToolbarGroupthat hosts a slot no longer clips the fan-out and folder panels of the buttons inside it — the slot section is only clipped while outgoing content is cross-fading out.